Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old xsec #448

Merged
merged 8 commits into from
Jul 11, 2022
Merged

Remove old xsec #448

merged 8 commits into from
Jul 11, 2022

Conversation

riclarsson
Copy link
Contributor

This removes most of the old XSEC code. It might be too wide. It also removes two test functions that were not run

@riclarsson
Copy link
Contributor Author

So I cannot fix the remaining issues of these tests:

107 - arts.ctlfile.fast.artscomponents.montecarlo.TestRteCalcMC (Failed)
108 - python.arts.ctlfile.fast.artscomponents.montecarlo.TestRteCalcMC (Failed)
185 - arts.ctlfile.xmldata.artscomponents.arts-xml-data.TestPlanetIsoRatios (Failed)
186 - python.arts.ctlfile.xmldata.artscomponents.arts-xml-data.TestPlanetIsoRatios (Failed)
201 - arts.ctlfile.fast.artscomponents.wfuns.TestSpectroscopy (Failed)
202 - python.arts.ctlfile.fast.artscomponents.wfuns.TestSpectroscopy (Failed)
203 - arts.ctlfile.planettoolbox.planetary_toolbox.demos.passive.DemoVenus_fullRT_1D_clearsky (Failed)
204 - python.arts.ctlfile.planettoolbox.planetary_toolbox.demos.passive.DemoVenus_fullRT_1D_clearsky (Failed)
305 - arts.pyarts.slow.artscomponents.surfaceblackbody.TestSurfaceBlackbody (Failed)
306 - arts.pyarts.fast.artscomponents.linemixing.TestMolOxyAdaptation (Failed)

Also, I really thing we should not be running all translated tests (or perhaps not translate all tests?). It is very annoying to have to run some of the slow tests taking almost 10 minutes TWICE.

For tests 107 and 108, the error is:
The MC path sampling has failed five times. A few failures should be OK, but this number is suspiciously high and the reason to these failures should be tracked down.

The errors seem to be related to non-positive temperatures. This is super weird as I changed nothing about how temperature should be treated; it has to be above 0 K. Perhaps previous test required 0 K???

For tests 185 and 186, the error is:

yREFERENCE-y FAILED!
Max allowed deviation set to: 2e-09
but the vectors deviate with: -0.00255508

This might be a compute package error or whatever. I have no idea what should change here...

The spectroscopy failure is known for some BLASes.

Tests 203 and 204, the failure is that the stokes_dim must be above 2 as it uses Faraday. Somehow, this was not tested before even though it is in the species list. It is not something I can fix.

The last two also fails because of moved files. They are OK to leave failing for this PR.

@olemke olemke marked this pull request as ready for review July 11, 2022 10:08
@olemke olemke merged commit 1814d56 into atmtools:master Jul 11, 2022
@riclarsson riclarsson deleted the remove_old_xsec branch July 21, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants