-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old xsec #448
Remove old xsec #448
Conversation
303dc83
to
3668160
Compare
So I cannot fix the remaining issues of these tests:
Also, I really thing we should not be running all translated tests (or perhaps not translate all tests?). It is very annoying to have to run some of the slow tests taking almost 10 minutes TWICE. For tests 107 and 108, the error is: The errors seem to be related to non-positive temperatures. This is super weird as I changed nothing about how temperature should be treated; it has to be above 0 K. Perhaps previous test required 0 K??? For tests 185 and 186, the error is:
This might be a compute package error or whatever. I have no idea what should change here... The spectroscopy failure is known for some BLASes. Tests 203 and 204, the failure is that the stokes_dim must be above 2 as it uses Faraday. Somehow, this was not tested before even though it is in the species list. It is not something I can fix. The last two also fails because of moved files. They are OK to leave failing for this PR. |
This removes most of the old XSEC code. It might be too wide. It also removes two test functions that were not run