Make gen_auto_py build withoug needing artscore #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves some stuff around to solve the problem of dependencies above. It has one key drawback: The default value of workspace variables cannot be printed anymore. It can still be accessed on an empty variable but it cannot be printed. I am not sure if this can be fixed or if there is a way to be self-referential in pyarts documentation somehow (e.g., access the variable some way while building the string that becomes the documentation)
Despite being documenting that this is added by py::return_value_policy::reference_internal, it appears this is not the case. Using just py::keep_alive<0, 1>() makes exiting python cause a memory corruption segfault, so it seems both are required to keep 1) the workspace alive as long as required, and 2) not cause memory corruption issues upon deleting an instance of the Workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some stuff around to solve the problem of dependencies above.
It has one key drawback: The default value of workspace variables cannot
be printed anymore. It can still be accessed on an empty variable but
it cannot be printed. I am not sure if this can be fixed or if there is
a way to be self-referential in pyarts documentation somehow (e.g., access
the variable some way while building the string that becomes the
documentation)
@olemke This should help your conda tree. I had to reduce on the documentation somewhat. I think this is fine in pyarts as we can just to ws.wsv.value to see the default though