Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't parse as unicode something which may not be a string. #3

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Don't parse as unicode something which may not be a string. #3

merged 1 commit into from
Feb 27, 2020

Conversation

quentinsf
Copy link
Contributor

While parsing the scene list on my hub, one of the chunks returned isn't valid unicode. Since we just discard the value anyway, I've changed unpack_string to unpack_bytes, which solves the problem.

atmurray
atmurray approved these changes Feb 27, 2020
View reviewed changes
Copy link
Owner

@atmurray atmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pick up, I might go through and change all discarded variable elements to unpack_bytes just incase.

@atmurray atmurray merged commit 02303dc into atmurray:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmurray atmurray atmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quentinsf @atmurray