Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] remove drawGutter #304

Closed
wants to merge 4 commits into from
Closed

[Performance] remove drawGutter #304

wants to merge 4 commits into from

Conversation

aminya
Copy link
Member

@aminya aminya commented Jun 2, 2020 •
edited
Loading

Fixes #303

After:
image

Before:
image

@aminya aminya changed the title Draw gutter performance [Performance] remove drawGutter Jun 2, 2020
This was referenced Jun 2, 2020
Merged
Merged
@aminya
Copy link
Member Author

aminya commented Jun 3, 2020 •
edited
Loading

The conflicts with master are too much. I am going to close this and open a new one if we wanted to remove drawGutter.

@aminya aminya closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[performance] Replace element.offsetHeight
1 participant
@aminya