Update to current TouchBar Electron API #312
Conversation
|
Also, I may be wrong, but I believe this fixes the issue described in #237. |
|
Thanks for this. I do not have a Mac to test this. If anyone of the other maintainers has they can review this. |
I don't so I can't test that either. @thatcomputerguy0101, is this the documentation on which the change is based? Did you try if the changes fixes the problem locally? If so, then I would be happy to merge this Pull Request.
Was your problem similar to what is described in that issue? If so I think it is safe to close that issue after this is merged 👍 |
Yes, the options parameter appears to have changed to an object. I have attached a screenshot of what the touch bar looks like with some buttons after I made this change locally.
After looking at that issue in more detail, I have determined that they are seperate problems. In my case, the touch bar was completely blank instead of just missing icons. Also, I have successfully reproduced that outcome on my own machine after this edit:
|
|
Alright, thanks for the followup @thatcomputerguy0101. In that case I will leave this for @suda to review, in case they can test this on a Mac with a touch bar. |
|
I'm not @suda, but I can confirm this fully fixes the issue, and by only adding { } around one little thing. |
thatcomputerguy0101
deleted the
thatcomputerguy0101-touchbar-api-patch
branch
On my installation, the touch bar didn't originally work. After looking at the Electron documentation, I noticed that the TouchBar API is still experimental. Comparing the code of this library to a working example, I have determined that the fix is to wrap 'items' within an object when it is passed to the TouchBar constructor. This PR contains that change.