This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Set the correct MSVS environment on Win32 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,8 @@ require 'colors' | |||
| config = require './config' | |||
| Command = require './command' | |||
|
|
|||
| isWin32 = !!process.platform.match(/^win/) | |||
There was a problem hiding this comment.
Hmm, maybe throw this in config.coffee as isWin32(), that way we could easily spy and mock it in the specs if we wanted to.
anaisbetts
pushed a commit
that referenced
this pull request
Aug 28, 2013
Set the correct MSVS environment on Win32
|
@xpaulbettsx I think we should not make Installing node@0.10.15 ✓
Installing modules ✗
> atom@0.1.0 preinstall C:\cygwin\home\zcbenz\codes\raven
> true
> int64-native@0.2.0 install C:\cygwin\home\zcbenz\codes\raven\node_modules\int64-native
> node-gyp configure && node-gyp build
C:\cygwin\home\zcbenz\codes\raven\node_modules\int64-native>node "C:\cygwin\home\zcbenz\codes\raven\vendor\apm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" configure
C:\cygwin\home\zcbenz\codes\raven\node_modules\int64-native>node "C:\cygwin\home\zcbenz\codes\raven\vendor\apm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" build
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Platforms\Win32\Microsoft.Cpp.Win32.Targets(511,5): error MSB8008: Specified platform toolset (v110) is not installed or invalid. Please make sure that a supported PlatformToolset value is selected. [C:\cygwin\home\zcbenz\codes\raven\node_modules\int64-native\build\Int64.vcxproj]
npm http GET https://atom.iriscouch.com/registry/_design/app/_rewrite/int64-native
npm http GET https://atom.iriscouch.com/registry/_design/app/_rewrite/int64-native
npm http GET https://atom.iriscouch.com/registry/_design/app/_rewrite/int64-native
npm http GET https://registry.npmjs.org/int64-native
npm http GET https://registry.npmjs.org/int64-native
npm http GET https://registry.npmjs.org/int64-native
gypnpm ERR! weird error 1
npm
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
script/bootstrap.pyon Windows by setting the correct VS version being sent tonode-gyp, found via nodejs/node-gyp#231