This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Updated package template with latest changes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
| # DOCUMENT: link to keymap documentation | ||
| 'body': | ||
| 'meta-alt-ctrl-o': '__package-name__:toggle' | ||
| # Keybindings require three things to be fully defined: the DOM element which |
There was a problem hiding this comment.
Instead of "the DOM element which they apply to" I'd say "A DOM selector" or "A selector that is matched against the focused element".
|
I renamed |
|
Okay I believe this is ready to 🚢 |
mcolyer
added a commit
that referenced
this pull request
Dec 2, 2013
Updated package template with latest changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put this together to fix #36
@probablycorey @kevinsawicki can you do a review when you get a chance to see if I'm missing anything here?