This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
node 12.4.0 - Electron 6 #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by @DeeDeeG:
Description of the Change
Update bundled Node to v12.4.0, which matches the version in Electron 6.
Alternate Designs
None. We intend to match the Node version in
apmto that which the version of Electron we use in Atom is based on.Our Atom is using Electron 6. So we should bundle Node v12.4.0 in
apm.Benefits
For packages that try to detect the version of Node they are building against during install, this closely approximates the version of Node used in Atom's version of Electron. So if there are any potential bugs in various packages due to non-matching versions of Node/Electron, this should take care of 99% of them, maybe even all of them.
Possible Drawbacks
None expected. This is just a minor version update of Node.
Verification Process
CI and manual testing, to be done soon.
Applicable Issues
For a discussion of the type of issue this is designed to address, see: #328