This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
GitHub actions #899
Merged
GitHub actions #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added x86 support to GitHub's setup-node. actions/setup-node#194 If they merge that PR sooner than you merge this PR, I will update this branch. Otherwise, it will be a follow-up. |
aminya
force-pushed
the
github-actions-4upstream
branch
from
adbc9b7
to
634cc07
Compare
|
My PR is finally merged. Now, we can use the official setup node with x86 support inside GitHub Actions. I have updated this PR accordingly. |
aminya
force-pushed
the
github-actions-4upstream
branch
from
634cc07
to
fc32606
Compare
DeeDeeG
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
👍
Note to maintainers: Please consider disabling AppVeyor and Travis for this repository and activating GitHub Actions when merging this.
I like using GitHub Actions for this repo (and this is what we did at the community fork) because it's much easier for users to get GitHub Actions running than to get Travis and AppVeyor both running.
aminya
commented
Jan 29, 2021
|
Thanks @aminya |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Use GithubActions instead of Travis and Appveyor. GitHubActions is much faster than the other CI services, and it is much easier to configure.
Verification
The CI passes: https://github.com/atom-ide-community/apm/actions/runs/413583758
Drawbacks
none
Release Notes
N/A