This repository has been archived by the owner on Sep 25, 2018. It is now read-only.
Make tab bottom border positioned relative to bottom #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simurai can you take a look at this? |
| position: fixed; | ||
| top: @tab-height + @tab-bottom-border-height; | ||
| position: absolute; | ||
| bottom: @tab-bottom-border-height - 1px; // - 1px border width |
There was a problem hiding this comment.
@ultramiraculous This line should stay as is. Otherwise it's a bit too high:
Or replacing it with bottom: 0; would work too.
|
@ultramiraculous I see the problem, yeah.. good point. If you fix the above issue, this should be good to merge. |
ultramiraculous
force-pushed
the
master
branch
from
f7b1763
to
60e9412
Compare
|
Fixed! |
simurai
added a commit
that referenced
this pull request
Jan 6, 2015
Make tab bottom border positioned relative to bottom
|
@ultramiraculous Thanks for the fix! It will introduce a new issue #38, but I think this one is still the more important to fix. |
|
When is this going to be released? It is still broken in 169. |
|
Should be in the next release (170). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both this theme and the light theme have the tab bar's underline positioned assuming the tab bar is the only thing in the top section. Anything added using atom.workspaceView.prependToTop will cause layout issues: