Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Windows crash reports on Azure build pipelines for pull requests only #19171

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@nathansobo
Copy link
Contributor

commented Apr 16, 2019

To combat hard crashes like #18991, we need access to crash the dumps produced by Electron for a given build on Windows. Crash reports leak environment variables, so we can't upload them as public artifacts on release branches. This PR will enable uploading on non-release branches, and I will follow up with a second PR to upload them to a private location for release branches.

Tasks:

  • Initial implementation for Azure build pipelines
  • Ensure passing PR builds still succeed when there are no crash reports to publish
  • Ensure failing PR builds with no crashes don't produce errors for build steps associated with crash report upload.
  • Ensure PR builds can publish crash dumps

@nathansobo nathansobo force-pushed the ns-upload-windows-crashes branch 6 times, most recently from adfa70f to d249fe1 Apr 17, 2019

@nathansobo nathansobo changed the title Upload crash dumps on Windows CI Upload Windows crash reports on Azure build pipelines for pull requests only Apr 18, 2019

@nathansobo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

I'm going to focus just on PR builds for now and focus on release branch builds in a subsequent PR. Updated the body accordingly.

@nathansobo nathansobo force-pushed the ns-upload-windows-crashes branch from d249fe1 to 1a50ede Apr 18, 2019

On Azure DevOps, publish crash reports on non-release Windows branches
Since we don't expose sensitive information on these branches, we can
use the regular artifact publishing mechanism

@nathansobo nathansobo force-pushed the ns-upload-windows-crashes branch from 1a50ede to b03d499 Apr 18, 2019

@nathansobo nathansobo requested a review from smashwilson Apr 18, 2019

@nathansobo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

I'm going to merge this so we can start getting crash reports on PRs ASAP. A review would still be appreciated though in case I should follow up with any adjustments.

@nathansobo nathansobo merged commit 6d3ebfa into master Apr 18, 2019

2 checks passed

Atom Pull Requests #20190418.12 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nathansobo nathansobo deleted the ns-upload-windows-crashes branch Apr 18, 2019

IF NOT EXIST "%ARTIFACT_STAGING_DIR%\crash-reports" MKDIR "%ARTIFACT_STAGING_DIR%\crash-reports"
IF EXIST "%Temp%\Atom Crashes" (
FOR %%a in ("%Temp%\Atom Crashes\*.dmp") DO XCOPY "%%a" "%ARTIFACT_STAGING_DIR%\crash-reports" /I
)

This comment has been minimized.

Copy link
@smashwilson

smashwilson Apr 19, 2019

Member

For future reference, you're not tied to batch here; you can use powershell to write in PowerShell instead:

- powershell: |
    if (Path-Exists "${env:ARTIFACT_STAGING_DIR}\crash-reports") {
      Create-Item -Type Directory "${env:ARTIFACT_STAGING_DIR}\crash-reports"
    }
    # etc
Show resolved Hide resolved script/vsts/platforms/windows.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.