Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Upload Windows crash reports on Azure build pipelines for pull requests only #19171

Merged
merged 1 commit into from Apr 18, 2019

Conversation

nathansobo
Copy link
Contributor

@nathansobo nathansobo commented Apr 16, 2019

To combat hard crashes like #18991, we need access to crash the dumps produced by Electron for a given build on Windows. Crash reports leak environment variables, so we can't upload them as public artifacts on release branches. This PR will enable uploading on non-release branches, and I will follow up with a second PR to upload them to a private location for release branches.

Tasks:

  • Initial implementation for Azure build pipelines
  • Ensure passing PR builds still succeed when there are no crash reports to publish
  • Ensure failing PR builds with no crashes don't produce errors for build steps associated with crash report upload.
  • Ensure PR builds can publish crash dumps

@nathansobo nathansobo force-pushed the ns-upload-windows-crashes branch 6 times, most recently from adfa70f to d249fe1 Compare April 18, 2019 16:05
@nathansobo nathansobo changed the title Upload crash dumps on Windows CI Upload Windows crash reports on Azure build pipelines for pull requests only Apr 18, 2019
@nathansobo
Copy link
Contributor Author

I'm going to focus just on PR builds for now and focus on release branch builds in a subsequent PR. Updated the body accordingly.

Since we don't expose sensitive information on these branches, we can
use the regular artifact publishing mechanism
@nathansobo
Copy link
Contributor Author

I'm going to merge this so we can start getting crash reports on PRs ASAP. A review would still be appreciated though in case I should follow up with any adjustments.

IF NOT EXIST "%ARTIFACT_STAGING_DIR%\crash-reports" MKDIR "%ARTIFACT_STAGING_DIR%\crash-reports"
IF EXIST "%Temp%\Atom Crashes" (
FOR %%a in ("%Temp%\Atom Crashes\*.dmp") DO XCOPY "%%a" "%ARTIFACT_STAGING_DIR%\crash-reports" /I
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, you're not tied to batch here; you can use powershell to write in PowerShell instead:

- powershell: |
    if (Path-Exists "${env:ARTIFACT_STAGING_DIR}\crash-reports") {
      Create-Item -Type Directory "${env:ARTIFACT_STAGING_DIR}\crash-reports"
    }
    # etc

script/vsts/platforms/windows.yml Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants