This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add delay to watch-path tests to make them less flaky #19459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathansobo
approved these changes
Jun 6, 2019
I don't think it hurts to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hate this PR, but that's the only way I've found to be able to fix the flakiness of the
path-watchertests (more info about the root cause on #19442 (comment)).This does not fix the root problem, which seems to be that on Electron v3,
nsfwsometimes needs several milliseconds to "warm up" on Windows to start receiving change events, but I've spent ~1 day debugging this and my current thinking is that fixing the root cause will take significantly longer.In order to remove the flakiness (which is quite brutal in
master), I've sent this PR.