Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay to watch-path tests to make them less flaky #19459

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented Jun 6, 2019

I hate this PR, but that's the only way I've found to be able to fix the flakiness of the path-watcher tests (more info about the root cause on #19442 (comment)).

This does not fix the root problem, which seems to be that on Electron v3, nsfw sometimes needs several milliseconds to "warm up" on Windows to start receiving change events, but I've spent ~1 day debugging this and my current thinking is that fixing the root cause will take significantly longer.

In order to remove the flakiness (which is quite brutal in master), I've sent this PR.

@rafeca rafeca requested review from nathansobo and as-cii Jun 6, 2019

@nathansobo
Copy link
Contributor

left a comment

Is it worth only awaiting on Windows or is it better to be consistent?

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

Is it worth only awaiting on Windows or is it better to be consistent?

I don't think it hurts to await on other platforms, and this way there's less platform-specific logic...

@rafeca rafeca merged commit fca0681 into master Jun 6, 2019

2 checks passed

Atom Pull Requests #20190606.13 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the fix-flaky-test branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.