Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use AppVeyor on release branches #19513

Merged
merged 1 commit into from Jun 14, 2019

Conversation

@jasonrudolph
Copy link
Member

commented Jun 12, 2019

#19508 will completely remove AppVeyor, but it will be a little while until we can merge that pull request. As noted in that pull request, our internal release publisher currently depends on AppVeyor for Windows build artifacts. That dependency affects Atom's release branches (e.g., 1.38-releases), but it doesn't affect other branches.

So while we still need AppVeyor for Atom's release branches, we no longer need it for any other branches. With the changes in this pull request, AppVeyor will still run on release branches, but it won't run on any other branches. This change will lessen the impact of the issues described in #19253.

@jasonrudolph jasonrudolph requested a review from nathansobo Jun 12, 2019

@jasonrudolph jasonrudolph self-assigned this Jun 12, 2019

@jasonrudolph jasonrudolph merged commit 229e8b9 into master Jun 14, 2019

1 check passed

Atom Pull Requests #20190613.3 succeeded
Details

@jasonrudolph jasonrudolph deleted the only-use-appveyor-on-release-branches branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.