This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Only use AppVeyor on release branches #19513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19508 will completely remove AppVeyor, but it will be a little while until we can merge that pull request. As noted in that pull request, our internal release publisher currently depends on AppVeyor for Windows build artifacts. That dependency affects Atom's release branches (e.g.,
1.38-releases), but it doesn't affect other branches.So while we still need AppVeyor for Atom's release branches, we no longer need it for any other branches. With the changes in this pull request, AppVeyor will still run on release branches, but it won't run on any other branches. This change will lessen the impact of the issues described in #19253.