This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Pass $PATH by command line #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested this on OS X Yosemite, and it works as excpected! Awesome job, @zcbenz 🌟 |
kevinsawicki
added a commit
that referenced
this pull request
Nov 5, 2014
Pass $PATH by command line
|
Thanks @zcbenz for fixing this. |
This was referenced Nov 5, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Yosemite the
$PATHis not inherited by theopencommand, so we have to explicitly pass it by command line to makeatomcommand inherit thePATHenvironment variable.Fixes electron/electron#550.