Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Problem with quotes #151

Closed
Jonahss opened this issue Mar 7, 2014 · 3 comments · Fixed by atom/atom#1857
Closed

Problem with quotes #151

Jonahss opened this issue Mar 7, 2014 · 3 comments · Fixed by atom/atom#1857
Assignees
Labels

Comments

@Jonahss
Copy link

Jonahss commented Mar 7, 2014

Quickly clicking the "replace next" button skips over successive double quotes.

To Reproduce:
-paste the following into a new document:

one double quote: '
a set of double quotes: '"
another solitary double quote: '

-search term: " replace term: '
-click the "Replace Next" button three times quickly

You will see that the third double quote gets skipped, and the fourth double quote gets replaced.

@hkdobrev
Copy link

hkdobrev commented Mar 8, 2014

I guess you meant:

one double quote: "
a set of double quotes: ""
another solitary double quote: "

I can reproduce the problem with this input.

The text you've posted is the actual result after clicking "Replace Next" three times.

@crowjonah
Copy link

Possibly related: Sometimes as a quick shortcut for fixing single/double quote mixing, I'll select one and cmd+d to select next, delete, and then type the character of my preference. For example, given

var thing = "just a string";

If I select the first " and choose Select Next from the menu (or hit cmd+d), the second " quote is not added to the selection.

I know there are better ways of doing this, but currently, the way Select Next functionality's behavior as it pertains to quotes prevents me from doing this, and probably other, more legitimate selections.

@kevinsawicki
Copy link
Contributor

This will be fixed in the Atom 0.85.0 release via the atom/text-buffer#17 and atom/text-buffer#18 PRs.

Thanks for the detailed reproduction steps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants