This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add a 'touch' invalidation strategy #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| {difference} = require 'underscore-plus' | |||
| TextBuffer = require '../src/text-buffer' | |||
|
|
|||
| describe "Marker", -> | |||
| fdescribe "Marker", -> | |||
There was a problem hiding this comment.
🔥 or are you still tweaking things?
There was a problem hiding this comment.
No that was a screwup. Gonna force push.
added 2 commits
April 10, 2014 11:12
A 'touch' marker is invalidated for any change that touches the marker, including changes that end at the marker's start position or start at the marker's end position. This was the former behavior of 'inside' markers, which are now only invalidated for changes that are truly *inside* the marker. This distinction allows find-and-replace markers to use the 'inside' strategy but spellcheck to use the 'touch' strategy. The logic is that an edit occurring adjacent to a find result doesn't invalidate the result, but an edit occurring next to a spellchecked word could actually change the word.
kevinsawicki
added a commit
that referenced
this pull request
Apr 10, 2014
Add a 'touch' invalidation strategy
|
💚 |
This was referenced Apr 10, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a 'touch' invalidation strategy that takes over the old behavior of 'inside'. Now the 'inside' strategy no longer invalidates for changes that abut the marker's range.
Closes #16.
/cc @kevinsawicki