Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix so dialogs are canceled when pressing escape/closing them #1452
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
The label for canceling a dialog needs to be "Cancel" or "No" so that when canceling the dialog either by pressing escape or by closing the dialog cancels the dialog. Otherwise these actions default to the first item. This can be a bad default choice for the force push dialog which would force push when you close the dialog.
There is a cancelId option according to the electron documentation but this is not supported on Windows.