This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Make review comments editable #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it can manage its own edit state
still thinking about how to structure the explanation
…hat the comment went under a different list so they are not confused.
Co-Authored-By: vanessayuenn <6842965+vanessayuenn@users.noreply.github.com>
This will let cmd/ctrl-enter fire the github:submit-comment event for review summary editors and existing comment editors, too.
Without this, the "edited" flair doesn't appear on a review comment or summary you edit until you perform a full refetch.
We added a few fields to PullRequestReview and PullRequestReviewComment, so we need to specify some defaults.
Codecov Report
@@ Coverage Diff @@
## master #2124 +/- ##
==========================================
+ Coverage 92.68% 92.72% +0.04%
==========================================
Files 213 215 +2
Lines 12188 12269 +81
Branches 1788 1796 +8
==========================================
+ Hits 11296 11376 +80
- Misses 892 893 +1
Continue to review full report at Codecov.
|
I've removed the callback parameter - using Promise fulfillment will be cleaner - and made the update methods re-throw caught mutation errors. I've also updated the callsite in ActionableReviewView to use await and try/catch to manage editing state. Now if the update mutation fails, users won't lose their edits.
This lets us inject mocks to test menu actions without having to do any crazy Electron shenanigans.
I've got everything but the cancel button tests.
Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
Co-Authored-By: Ash Wilson <smashwilson@gmail.com>
kuychaco
commented
May 15, 2019
| await this.props.contentUpdater(this.props.originalContent.id, text); | ||
| this.setState({editing: false}); | ||
| } catch (e) { | ||
| this.buffer.setText(text); |
There was a problem hiding this comment.
So we'd get to this catch block when the update mutation fails, and if I'm understanding Relay mutations correctly then the optimistic update will automatically get rolled back, and the original text will be restored to the buffer. So I think it may not be necessary to manually restore the text here... though I guess it couldn't hurt to do so and be 100%.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting work to address #2112. Will add writeup shortly!
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Screenshot/Gif
Alternate Designs
Benefits
Possible Drawbacks
Applicable Issues
Metrics
Tests
Documentation
Release Notes
User Experience Research (Optional)