Make review comments editable #2124
Starting work to address #2112. Will add writeup shortly!
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
User Experience Research (Optional)
The text was updated successfully, but these errors were encountered:
…hat the comment went under a different list so they are not confused.
Co-Authored-By: vanessayuenn <email@example.com>
This will let cmd/ctrl-enter fire the github:submit-comment event for review summary editors and existing comment editors, too.
@@ Coverage Diff @@ ## master #2124 +/- ## ========================================== + Coverage 92.68% 92.72% +0.04% ========================================== Files 213 215 +2 Lines 12188 12269 +81 Branches 1788 1796 +8 ========================================== + Hits 11296 11376 +80 - Misses 892 893 +1
I've removed the callback parameter - using Promise fulfillment will be cleaner - and made the update methods re-throw caught mutation errors. I've also updated the callsite in ActionableReviewView to use await and try/catch to manage editing state. Now if the update mutation fails, users won't lose their edits.