This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Devel: Better recognition of newer Java versions #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 6, 2021 00:47
- global.stress is never used - atom-mocha-test-runner does not allow any configuration parameter called overrideTestPaths and mocha.js neither
|
Any updates on when this fix will be merged and available in the release? |
I think this is dead repo. |
|
what does the code do |
|
I changed regexp to allow also dot as possible delimiter at 3rd position in version for Java. |
|
oh ok thanks |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#137
Description of the Change
I changed a little bit the REGEXP in getJavaVersionFromOutput() inside the lib/main.js file to be able to recognize Java versions which consists of 3rd dot in java version number.
I also added test for it in test/main.test.js.
This maybe should not be part of this pull request but I also changed test/runner.js and autoImport.....test.js as described in commits.
Please be patient this it my first contribution at GitHub.
Thank you for your time.
Alternate Designs
I considered redesigning the REGEXP and tests for this function but it could be a mess.
Now it is rather a small change with an understandable diff.
Possible Drawbacks
IDK, the change only adds underscore as the variant into REGEXP at specific position which was not changed.
Verification Process
npm testwhere each test passed including the new one without problem.Release Notes
Better recognition of newer Java versions.