Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

module name and comments not highlighted in module-info.java #245

Open
Eskibear opened this issue Jan 20, 2021 · 4 comments
Open

module name and comments not highlighted in module-info.java #245

Eskibear opened this issue Jan 20, 2021 · 4 comments

Comments

@Eskibear
Copy link
Contributor

Description

Also reported in redhat-developer/vscode-java#1384
JEP reference about module system: https://openjdk.java.net/jeps/261

image

Expected behavior:

  • com.foo.bar and java.base should be highlighted.
  • comments in Line 4 should be hightlighted.

Versions

it's tested on vscode@1.53.0-insiders, should be latest release of atom/language-java
@Eskibear
Copy link
Contributor Author

@sadikovi Can you take a look please? FYI that we might be able to work "module names" around via semantic highlighting. So comments part should have a higher priority if you are short of bandwidth...

@Eskibear Eskibear mentioned this issue Jan 20, 2021
Merged
@Eskibear
Copy link
Contributor Author

I just created a PR against the comments part. please take a look.

sadikovi pushed a commit that referenced this issue Jan 23, 2021
@Eskibear
Highlight comments in module (#246)
29f977d 
Signed-off-by: Yan Zhang <yanzh@microsoft.com>

### Requirements

* Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
* All new code requires tests to ensure against regressions

### Description of the Change

<!--

We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts.

-->

To enable comments and javadocs in `module`

### Alternate Designs
unknown
<!-- Explain what other alternates were considered and why the proposed version was selected -->

### Benefits
To fix part of #245 
<!-- What benefits will be realized by the code change? -->

### Possible Drawbacks
unknown
<!-- What are the possible side-effects or negative impacts of the code change? -->

### Applicable Issues

#245 
<!-- Enter any applicable Issues here -->
@sadikovi
Copy link
Contributor

Shall we close this issue or is there anything else left to do?

@Eskibear
Copy link
Contributor Author

com.foo.bar and java.base should be highlighted.

It would be better if qualified module names can be highlighted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eskibear @sadikovi