Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add DQL support #448

Merged
merged 2 commits into from
May 20, 2022
Merged

Add DQL support #448

merged 2 commits into from
May 20, 2022

Conversation

eexit
Copy link
Contributor

@eexit eexit commented Jan 20, 2022

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Hello,

This tiny PR adds support for Doctrine Query Language syntax coloration in heredocs.

Example:

dql-support

Thanks!

Alternate Designs

Benefits

Possible Drawbacks

Applicable Issues

grammars/php.cson Outdated Show resolved Hide resolved
grammars/php.cson Outdated Show resolved Hide resolved
Copy link
Contributor

@KapitanOczywisty KapitanOczywisty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@eexit
Copy link
Contributor Author

eexit commented Feb 15, 2022

Hello, any update on this?
Thanks!

@KapitanOczywisty
Copy link
Contributor

Merging PRs takes a while here.

@eexit
Copy link
Contributor Author

eexit commented May 20, 2022

Hello, any update? It's been 5 months now 🙃

@KapitanOczywisty
Copy link
Contributor

I told you :) @darangi @sadick254 any chance to merge some PRs? This and #456

@darangi
Copy link
Contributor

darangi commented May 20, 2022

@KapitanOczywisty @eexit We will take a look at the PRs

@darangi
Copy link
Contributor

darangi commented May 20, 2022

Thanks for the contribution 🙇🏾 @eexit

@darangi darangi merged commit adf8d88 into atom:master May 20, 2022
@eexit
Copy link
Contributor Author

eexit commented May 20, 2022

Anytime!

@eexit
Copy link
Contributor Author

eexit commented Jul 7, 2022

Hey @darangi, will you plan to ever release the latest merges? Latest release is from Jan 17th...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants