Coloring of strings could be misleading

[nicolaiskogheim]

I just had an issue with a line of code like this:

script: "coverage report --omit="*__init__.py""

It took me a little while to figure out my copypaste error with the nested double quotes.

This is the same line with githubs .yml syntax coloring

script: "coverage report --omit="*__init__.py""

There it is very easy to see where I went wrong.

Screen from atom

[floscher]

This is the same line with githubs .yml syntax coloring

script: "coverage report --omit="*__init__.py""

There it is very easy to see where I went wrong.

GitHub also uses this grammar for syntax highlighting, so by now it has the same appearance as in atom ;-)

Currently e.g. JSON-highlighting still shows the behaviour you probably meant:

[nicolaiskogheim]

Good catch! You are absolutely right. Pity that Github has this issue now.

[winstliu]

I took a look at this and I don't believe this is a bug. The quoted parts get string.quoted.double.yaml, while the unquoted part (*__init__.py) gets string.unquoted.yaml. Those two can be styled differently.

I'm closing this, but please feel free to correct me if I'm wrong.

[nicolaiskogheim]

Ah, okay. Thank you for taking a look :)

[winstliu]

After some thought I've decided to reopen this as we really shouldn't be highlighting that inner segment as unquoted strings.