This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Only minor syntactic sugar removed from ES6 to ES5 #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2017
It looks like |
I did the comment out after converting to ES5 and left the comments for easy review.
|
Looks good to me. What do you think, @maxbrunsfeld? |
would love to know the status on this! |
Let's make it happen! Do we want to first update the travis config to test on more node versions? 4, 6, 8? |
thanks @zeke! 4, 6, and 8 seems good to me. i'm happy to make the travis PR if you'd like as well. just lemme know! |
@zeke ? would love to get this merged |
Merged
I want to see this passing on node 4, 6, and 8 first. I can't edit this PR, so I've opened a followup to it: #71 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Approach