-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwriting /api #71
Comments
That does seem a little silly, doesn't it? The trivial solution to this is to serve the However, I don't know if any @zeke , @wmhilton , any preference or insight here? |
I definitely don't think it's silly. :) Of course it's easy to bypass the limitation if you're willing to settle for a less clean URL. I think however that the It's obviously not a deal breaker, but still a bit annoying. I agree that it would be nice to make the current Just my ¢2! |
A third option could be that, when hitting the /API endpoint, Jus first checks whether the user has defined that route themselves in the file structure. If they have, then load that page. If not, just show the default JSON data as it does now. Unless the /api endpoint is used internally by the library for some reason I think that could be a good solution too. |
cli.js
routes.js
Usage
Rationale
Note:@zeke @jdormit @wmhilton We need to do something about |
@elingerojo Oh man, I hadn't tried running |
@jdormit ...we are unable to do PR without CI-Travis and Appveyor complaints since the 20th of April because
|
Hey people sorry for the silence. I've been offline on parental leave for the last month. 🌴 I work with the atom team at GitHub, so I can take a look at that oniguruma PR and see if we can get a new version of it out. If it ends up being difficult, I would be open to releasing a new major version of jus that intentionally drops node 4 support. I would also be open to allowing a command-line option to specify the API path. Or, as @t4t5 suggested, checking whether the user has defined the api route. @t4t5 would you be interesting in submitting a PR to support that behavior? |
I already have a local branch ready to PR but we are stuck with CI-Travis and Appveyor complaining for the As soon as we can PR again, will submit the branch with the CLI api path option |
Just created an api-configurable-endpoint branch at my jus fork.
Issues before doing a PR to jus/jus
|
I have a little problem. I started using jus (awesome project btw) to generate some docs for the upcoming SweetAlert release.
I want to have a /api route that explains the library's API. However, it seems like that URL is occupied in order to show some internal stuff. :)
Would you consider changing that URL, or at least making it overwriteable? I think having an /api route is a pretty common use case for library documentation (which seems to be the primary usage of jus)!
The text was updated successfully, but these errors were encountered: