Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: npm contexter dependency :wip: #70

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Conversation

elingerojo
Copy link
Member

WIP: do NOT merge

@wmhilton This is NOT the snack sized version. I am still working on that ...but I surely appreciate a quick feedback about the general approach

Modularizing jus

@zeke I think, I nailed.

  • Removed the parse and render operations from jus (now jus is free to add any parsing/rendering libraries at will!)

  • Created npm contexter. This PR has a new dependency npm contexter (and dropped some others not needed anymore)

  • jus.js gets very simple (and could be simpler by using other optional events)

contexter_npm_sample

Not looking for merge approval this PR is for review convenience

  • all tests pass OK
  • still backwards compatible, tested with:
    • jus.js.org
    • zeke.sikelianos.com
    • acrophony


Test drive with contexter-cli

...also created npm contexter-cli for test drive the library

contexter-cli_npm_sample

It starts a server to show the dir to context in action

homepage

contexter library could be extended through plugins

  • to different file types ( layouts, pages, stylesheets, customTypes, ... )
  • to different context object formats ( like snakecased keyName, deeper or shallow structures, ... )
  • to any file process like parse, render, minimize, write, extract, ...
  • in any flavor like (marky-markdown-lite, next-css, ...)

Update to jus/jus master 0.24.0
@elingerojo
Copy link
Member Author

elingerojo commented Apr 21, 2017

Found the travis-ci checks failures cause

Looks like atom/node-oniguruma broke Node 4 support in in latest minor release

So any new jus installation below Node 6.4 will not work 😢

They are already aware of it, so I will wait a little bit before trying any workaround

@elingerojo
Copy link
Member Author

Submitted a PR to atom/node-oniguruma to fix their Node 4 support issue

Hope they can review soon because master jus is not working for new installations with Node below 6.4

@elingerojo elingerojo mentioned this pull request May 1, 2017
@elingerojo
Copy link
Member Author

@zeke

I can take a look at that oniguruma PR and see if we can get a new version of it out. If it ends up being difficult, I would be open to releasing a new major version of jus that intentionally drops node 4 support.

This PR could be the start for a new major version of jus without droping node 4 support

  • I replaced marky-markdown by markdown-it to remove oniguruma dependency
  • It is based on npm contexter so new parsers are just new plugins (I already built a css-next plugin to replace myth)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant