Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Wait for save to complete in tests #222

Merged
merged 1 commit into from
May 23, 2017
Merged

Conversation

maxbrunsfeld
Copy link
Contributor

The TextBuffer.save method is going to become async in atom/atom#14435; instead of doing a synchronous write, it will initiate an asynchronous write and return a promise when the write completes. This shouldn't affect the user-facing functionality of many packages; but several packages may have test failures.

This PR updates the two tests in symbols-view that broke due to this change, so that they work regardless of whether save is synchronous or asynchronous.

@maxbrunsfeld maxbrunsfeld merged commit 6bdb9f4 into master May 23, 2017
@maxbrunsfeld maxbrunsfeld deleted the mb-wait-for-save-in-tests branch May 23, 2017 14:05
This was referenced Jun 14, 2017
This was referenced Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant