This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Clear selections tail when they become empty after a text change #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as-cii
force-pushed
the
clear-remote-selections-tail-after-text-changes
branch
from
fc14601
to
0ba13c4
Compare
as-cii
changed the title
as-cii
changed the title
|
Tests currently fail because we need to merge atom/text-buffer#261 first and bump text-buffer both on master and beta. |
|
Okay, that text-buffer PR is on |
as-cii
changed the title
as-cii
force-pushed
the
clear-remote-selections-tail-after-text-changes
branch
3 times, most recently
from
b2fd774
to
93cd55e
Compare
added 4 commits
September 29, 2017 11:55
Originally, we attempted to solve this by relaying the `exclusive` parameter from the site owning the marker. This was, however, inaccurate because selections only become exclusive if text changes and the selected region becomes empty. For this reason, similarly to what we do in [selection.coffee](https://github.com/atom/atom/blob/a3e98d54e3d24bbc5c4a67a135cfae2744805285/src/selection.coffee), we will observe remote selection markers, and if they move as a result of a text change, we will clear the tail if their range becomes empty.
as-cii
force-pushed
the
clear-remote-selections-tail-after-text-changes
branch
from
93cd55e
to
0538d57
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on atom/text-buffer#261
Fixes #61
Originally, we attempted to solve this by relaying the
exclusiveparameter from the site owning the marker. This was, however, inaccurate because selections only become exclusive if text changes and the selected region becomes empty.For this reason, similarly to what we do in selection.coffee, we will observe all selection markers, and if they move as a result of a text change, we will clear the tail if their range becomes empty.
/cc: @nathansobo @jasonrudolph @ungb @rsese @Ben3eeE