This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Emit text and marker change events when skipping undo #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #255 we introduced a regression that prevented the following events from firing when calling
setTextInRange
withundo: 'skip'
:buffer.onDidChangeText
buffer.onDidStopChanging
markerLayer.onDidUpdate
marker.onDidChange
This pull-request fixes it by calling
emitMarkerChangeEvents
andemitDidChangeTextEvent
at the end ofsetTextInRange
if the transact call depth is0
andundo
is'skip'
./cc: @nathansobo