This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Support scoped settings #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default jade to removeWhitespace: false
| @@ -62,10 +62,20 @@ describe "Whitespace", -> | |||
| atom.config.set("whitespace.removeTrailingWhitespace", false) | |||
|
|
|||
| it "does not trim trailing whitespace", -> | |||
| editor.insertText "don't trim me " | |||
| editor.insertText "don't trim me \n\n" | |||
There was a problem hiding this comment.
Without these, it doesnt event trim with atom.config.set("whitespace.removeTrailingWhitespace", true) cause of ignoreWhitespaceOnCurrentLine.
|
I tried and search how to achieve the same thing with slim (ruby-slim as well as slim-language packages): [EDIT] Please see the solution in #72 (comment). The right scopeName is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for scoped settings. All the settings are now scoped to language.
.source.jadelanguage defaultsremoveTrailingWhitespaceto false.Additionally, now you can override these in your config file on a per language basis. For example:
Closes #36