Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small error introduced in PR 106 #107

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

timcallow
Copy link
Contributor

A very small error in the set-up of the neumann matrices was introduced by mistake in PR #106, when I was playing around with the boundary conditions. Actually the reason it got through is because it has an imperceptibly small impact on results (something to do with forward / backward difference formulae for derivatives). Anyhow now it is switched back to how it should be.

@timcallow timcallow merged commit a1dae7e into atomec-project:develop Dec 9, 2021
@timcallow timcallow deleted the fix_neumann_matrix branch December 9, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants