Change the way libxc is installed
#203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcallow
force-pushed
the
libxc_change_install
branch
from
d2615c8
to
6502f40
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #203 +/- ##
===========================================
+ Coverage 91.56% 91.69% +0.13%
===========================================
Files 14 14
Lines 2394 2396 +2
===========================================
+ Hits 2192 2197 +5
+ Misses 202 199 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
pip install libxc2to installlibxc, but this package is not officially supported and does not seem to be actively maintained. For example, it breaks for Python > 3.9.In this PR, we switch the default installation of libxc to use the official route, which means building the shared libs and Python bindings from source. This means we can keep up with libxc releases, and also use more up-to-date Python versions.