Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mixfrac explicit in tests #206

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

timcallow
Copy link
Contributor

Tests were sometimes failing unexpectly, this is because the mixfrac parameter has to be explicitly reset

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8e80f1c) 91.69% compared to head (ba34b88) 97.03%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #206      +/-   ##
===========================================
+ Coverage    91.69%   97.03%   +5.34%     
===========================================
  Files           14       14              
  Lines         2396     2396              
===========================================
+ Hits          2197     2325     +128     
+ Misses         199       71     -128     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timcallow timcallow merged commit 1d3333a into atomec-project:develop Oct 10, 2023
6 checks passed
@timcallow timcallow deleted the fix_tests branch October 10, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant