Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec branch #157

Merged
merged 8 commits into from
Feb 24, 2017
Merged

Spec branch #157

merged 8 commits into from
Feb 24, 2017

Conversation

emdurr
Copy link
Contributor

@emdurr emdurr commented Feb 24, 2017

Code-review checklist

  • Documentation
    • Interfaces describe how other programmers would use them.
    • Code that is not obvious has documentation describing why
      that code is the way it is.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.379% when pulling 784fe87 on spec_branch into 55c1623 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.379% when pulling fdd3478 on spec_branch into 55c1623 on master.

Copy link
Contributor

@jbasdf jbasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbasdf jbasdf merged commit 31cb2bf into master Feb 24, 2017
@jbasdf jbasdf deleted the spec_branch branch February 24, 2017 22:43
coleshaw referenced this pull request in CLIxIndia-Dev/OpenAssessmentsClient Feb 27, 2017
* Adds confirmation to delete (#148)

* fixes the back button https://www.pivotaltracker.com/story/show/137834749 (#146)

* hides stuff if inactive (#147)

* Single item or full page (#149)

* starting to get offered

* if not published take embed code option away

* refactor assessOffered cleaner

* fix name and killed lambda()

* set genusTypeId of single page

* PR review changes

* changes from PR

* Makes feedback work (#151)

* show if editable delte (#150)

* fixes the refresh in edit assessment (#153)

* fixes the refresh in edit assessment

* changes languages options

* copy stuffs to clipboard (#152)

* copy stuffs to clipboard

* moved to correct pkg json

* delete react

* if not titled assessment, doesn't show questions (#156)

* checkboxes for only multiple choice for now (#155)

* Languages (#154)

* copy stuffs to clipboard

* moved to correct pkg json

* delete react

* change languages

* updated language codes

* Spec branch (#157)

* two spec files created

* spec files

* new spec to add

* spec fixes, temp xit of delete functions

* note addition

* file with qbank server url (#158)

* file with qbank server url

* refactor for the better

* works

* better naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants