Skip to content
This repository has been archived by the owner on Nov 9, 2024. It is now read-only.

*-start/*-end placement with followCursor option reversed + incorrect offset (v4.3.2) #513

Closed
lozinsky opened this issue Jun 3, 2019 · 6 comments
Labels

Comments

@lozinsky
Copy link
Contributor

lozinsky commented Jun 3, 2019

Bug description

Thanks for the backport v5 fixes to v4 (#511).
In the case where the placement option has *-start/*-end value and followCursor option is defined, tippy is placed on the other side of the cursor in 4.3.2 version. Is this a new expected behavior or bug?

Reproduction

CodePen link (4.3.1): https://codepen.io/lozinsky/pen/MdLzwo
CodePen link (4.3.2): https://codepen.io/lozinsky/pen/JqxeYa

@atomiks
Copy link
Owner

atomiks commented Jun 3, 2019

I think it's actually correct now. Before, the virtual reference had zero size but now it actually has a "fake size" of 100 pixels which prevents some issues. It looks like that ended up reversing the behavior though.

Though it does seem to be offset by 8 pixels now, so there could be something wrong here.

@atomiks
Copy link
Owner

atomiks commented Jun 3, 2019

If you add arrow: true and comment out followCursor: true, you'll see the placement seems to actually be correct in 4.3.2. But I don't know about the slight pixel offset now.

@lozinsky
Copy link
Contributor Author

lozinsky commented Jun 3, 2019

If I want tippy to be near the cursor as in version 4.3.1 I need to add offset: "50, 0"?

@atomiks
Copy link
Owner

atomiks commented Jun 3, 2019

I think the reversement of placement is correct now (although kind of a breaking change from previous behavior? 😕), but the offset problem is a bug. It changes based on the tooltip element's size.

@atomiks atomiks changed the title *-start/*-end placement behavior with followCursor option (v4.3.2) *-start/*-end placement with followCursor option reversed + incorrect offset (v4.3.2) Jun 3, 2019
@ohana88

This comment has been minimized.

@ohana88

This comment has been minimized.

atomiks added a commit that referenced this issue Jun 3, 2019
@atomiks atomiks closed this as completed in 5c4f809 Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants