This repository has been archived by the owner on Nov 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes atomiks/tippyjs-react#67
Changes the "notransition" technique which fixes undesirable transitions when the tippy changes placements on updates.
Before: add a
transition: none
CSS class on the tippy onceonShown()
completesAfter: use some instance flags to check if the previous placement is the same and if the previous update happened while the tippy was visible. If so, disable transitions for a single frame before painting. This is a better way to do it anyway and it fixes the problem linked
(going to be deleting the comments describing the variables after this as they're quite redundant, that's why I didn't add any here)