Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown rendering on the terminal is limited by performance #123

Closed
jessitron opened this issue Aug 21, 2018 · 0 comments · Fixed by #141
Closed

Markdown rendering on the terminal is limited by performance #123

jessitron opened this issue Aug 21, 2018 · 0 comments · Fixed by #141
Labels
blocker bug Something isn't working changelog:fixed Add this issue or pull request to fixed changelog section
Milestone

Comments

@jessitron
Copy link
Contributor

Investigating #76 , we noticed that rendering a list of 16 commands never finished.
from testing:
// 3s for 12 (at 943 characters)
// 10s for 13
// 50s for 14

This is a performance limitation. We upgraded to marked@0.5.0 but the problem is still there.

Our workaround is to skip markdown rendering for messages longer than 1000 characters / 12 lines.

A better-performing parser would be better.

@jessitron jessitron added this to the future milestone Aug 21, 2018
cdupuis added a commit that referenced this issue Aug 24, 2018
@cdupuis cdupuis added bug Something isn't working changelog:fixed Add this issue or pull request to fixed changelog section blocker labels Aug 24, 2018
atomist-bot added a commit that referenced this issue Aug 24, 2018
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Something isn't working changelog:fixed Add this issue or pull request to fixed changelog section
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants