Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide spawnLog with consistent spawn interface #620

Merged

Conversation

ddgenome
Copy link
Contributor

Rather than have a separate log argument, just make the log option
property not optional. Update code throughout.

@ddgenome ddgenome added the auto-merge:on-approve Auto-merge on review approvals label Dec 13, 2018
@cdupuis cdupuis added the changelog:added Add this issue or pull request to added changelog section label Dec 13, 2018
@ddgenome ddgenome force-pushed the child-process-on-project-delog branch from 6fbdc2e to 1c88c44 Compare December 13, 2018 16:22
Rather than have a separate log argument, just make the log option
property not optional.  Update code throughout.
@ddgenome ddgenome force-pushed the child-process-on-project-delog branch from 1c88c44 to a66610f Compare December 13, 2018 16:25
@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit fdff9b3 into child-process-on-project Dec 13, 2018
@atomist-bot atomist-bot deleted the child-process-on-project-delog branch December 13, 2018 17:04
atomist-bot added a commit that referenced this pull request Dec 13, 2018
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants