Add volumeClaimTemplates to raft storage api #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuujo
reviewed
Apr 26, 2020
deploy/raft-storage-controller.yaml
Outdated
| @@ -181,7 +168,7 @@ metadata: | |||
| subjects: | |||
| - kind: ServiceAccount | |||
| name: raft-storage-controller | |||
| namespace: kube-system | |||
| namespace: default | |||
There was a problem hiding this comment.
If this is a cluster scoped controller it should be deployed in the kube-system namespace as is convention for all controllers
kuujo
reviewed
Apr 26, 2020
| default: 1 | ||
| volumeClaimTemplates: |
There was a problem hiding this comment.
Can we just convert this to YAML just so it's clear and so we're sure we can use it in the Helm chart as well?
There was a problem hiding this comment.
I will figure that out. It looks like it is working in helm chart as well :)
adibrastegarnia
force-pushed
the
add_new_pvc
branch
from
1b211d8
to
de9930c
Compare
|
@kuujo |
adibrastegarnia
force-pushed
the
add_new_pvc
branch
3 times, most recently
from
0696d7b
to
ad4c6a7
Compare
adibrastegarnia
force-pushed
the
add_new_pvc
branch
from
ad4c6a7
to
f6203b2
Compare
adibrastegarnia
commented
Apr 27, 2020
| replicas: 1 | ||
| partitionsPerCluster: 3 | ||
| volumeClaimTemplates: |
There was a problem hiding this comment.
Should we keep this here as an example?
adibrastegarnia
commented
Apr 27, 2020
| partitionsPerCluster: | ||
| type: integer | ||
| min: 1 | ||
| max: 1024 | ||
| minimum: 1 |
There was a problem hiding this comment.
This should be updated in helm charts as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More testing will be needed.