Add workaround for crash related to call_ext_last/3
#518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
requested changes
Apr 23, 2023
pguyot
force-pushed
the
w16/fix-call_ext_last-throw-stack_base
branch
from
a941456
to
661cf98
Compare
pguyot
commented
Apr 24, 2023
|
We actually may need to adopt OTP23+ stack model introduced in erlang/otp#2351 to fix this crash. I am not totally sure of the semantics of |
BEAM's compiler and especially beam_trim optimization pass can generate an incorrect deallocation `n_words` parameter for `call_ext_last/3`. As a workaround, deallocate after the nif call, and before any error handling that may need the stack to find catch handlers. See: erlang/otp#7152 Add test that currently crashes on master without this change Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w16/fix-call_ext_last-throw-stack_base
branch
from
661cf98
to
b9ba453
Compare
pguyot
changed the title
call_ext_last/3
bettio
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEAM's compiler and especially beam_trim optimization pass can generate an
incorrect deallocation
n_wordsparameter forcall_ext_last/3.As a workaround, deallocate after the nif call, and before any error handling
that may need the stack to find catch handlers.
See: erlang/otp#7152
Add test that currently crashes on master without this change
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later