Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add unit test for error during sync #669

Merged
merged 2 commits into from
Aug 25, 2022
Merged

fix: add unit test for error during sync #669

merged 2 commits into from
Aug 25, 2022

Conversation

murali-shris
Copy link
Member

- What I did

  • added a unit test to replicate error during sync
    - How I did it
  • added a new test to sync_service_test.dart
  • one entry of the batch has invalid data type for commit id.This entry will thrown an error and skipped. Other entries should get processed
    - How to verify it
  • run the unit test - "A group of tests to validate exception during sync processing" to sync_service_test.dart

@murali-shris murali-shris mentioned this pull request Aug 25, 2022
Closed
@murali-shris murali-shris linked an issue Aug 25, 2022 that may be closed by this pull request
Add tests to catch sync issues #627
Closed
@gkc gkc merged commit f918857 into trunk Aug 25, 2022
@gkc gkc deleted the sync_tests branch August 25, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@sitaram-kalluri sitaram-kalluri sitaram-kalluri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests to catch sync issues
3 participants
@murali-shris @gkc @sitaram-kalluri