Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gui namespace #440

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix: gui namespace #440

merged 1 commit into from
Sep 8, 2023

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Sep 8, 2023 •
edited
Loading

- What I did

  • Set the sshnp_gui namespace to the same one as the sshnoports package uses (SSHNPD.namespace)
  • This caused a bug in the gui with fix: send ssh public key #439 since the sshpublickey wasn't being shared correctly when using the gui, this will prevent further issues if the namespace of a key is not explicit.

- How I did it

- How to verify it

- Description for the changelog
fix: gui namespace

@gkc gkc merged commit b0f44e0 into sshnp-gui Sep 8, 2023
1 check passed
@gkc gkc deleted the fix/gui-namespace branch September 8, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@CurtlyCritchlow CurtlyCritchlow Awaiting requested review from CurtlyCritchlow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XavierChanth @gkc