This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Improve ingress controller handling in deckhand_load_yaml script #18
Comments
|
The --replace flag should also be used in the "shipyard create configdocs" command, to allow for iterative YAML corrections and re-execution of this script to get past validation errors. |
|
Issues will be addressed by https://review.gerrithub.io/#/c/396340/ |
jenkins-attcomdev
pushed a commit
that referenced
this issue
Jan 26, 2018
This Patch Set is meant to address Shipyard issue #18 [0] Issues Identified: 1) The deckhand_load_yaml.sh script does not check if the ingress_controller_ip returned a null value. This may result in invalid entries written to /etc/hosts. 2) The subsequent DNS entries written to /etc/hosts are not idempotent, so script re-runs (e.g., after discovering and resolving YAML validation errors) will result in duplicate (and possibly disagreeing) DNS entries written to /etc/hosts. 3) The '--replace' flag should also be used in the "shipyard create configdocs" command, to allow for iterative YAML corrections and re-execution of this script to get past validation errors. [0] #18 Change-Id: I33531d07a5d6c425071af99c8824c12d3e177e69
|
The p.s. has been reviewed and merged. This issue will be closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently the deckhand_load_yaml.sh script does not check that the
ingress_controller_ipreturned a non-null value, which may result in invalid entries written to /etc/hosts.Also, the subsequent DNS entries written to /etc/hosts are not idempotent, so script re-runs (e.g., after discovering and resolving YAML validation errors) will result in duplicate (and possibly disagreeing) DNS entries written to /etc/hosts.
The text was updated successfully, but these errors were encountered: