Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix invalid use of memccpy() on master #1481

Closed
McDutchie opened this issue Jun 12, 2020 · 5 comments
Closed

Please fix invalid use of memccpy() on master #1481

McDutchie opened this issue Jun 12, 2020 · 5 comments

Comments

@McDutchie
Copy link
Contributor

The official AST master branch should at the very least fix a blatantly invalid use of memccpy() on potentially overlapping buffers in the commonly used library function sfputr(). See #78. The fix can easily be cherry-picked from commit dda258b.

On the Mac, this makes various crashes magically vanish.

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Jun 12, 2020

This repo is inactive - please see #1466 and #1464 (comment) onward.

Please search the web for a maintained version of ksh2020 or ksh93. Thanks!

@McDutchie
Copy link
Contributor Author

McDutchie commented Jun 12, 2020

I'm well aware. I think you should make an exception for this one. It's such an easy fix and it solves various crashes.


Edit: re actively maintained version: see https://github.com/ksh93/ksh

@gordonwoodhull
Copy link
Contributor

Sorry, didn't recognize you.

Thanks for linking to your active repo - that's one of the reasons we are not archiving this one.

@lkoutsofios
Copy link
Collaborator

lkoutsofios commented Jun 12, 2020 via email

@McDutchie
Copy link
Contributor Author

Done in d277191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants