Fix copying overlapping buffers in hist_word() #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came to light as a consequence of @siteshwar adding unit tests for interactive emacs mode editing behavior.
|
LGTM |
hyenias
added a commit
to hyenias/ksh
that referenced
this pull request
Mar 20, 2021
While experimenting with ksh93#233, a memory segmentation fault occurred. A search of other emacs issues found a potential matching issue as described in att#791. Also, a duplicate PR of att#1489 was submitted. This commit backports that fix. src/cmd/ksh93/edit/history.c: hist_word(): - Switch from using strcpy to memmove as the two strings could overlap.
McDutchie
pushed a commit
to ksh93/ksh
that referenced
this pull request
Mar 20, 2021
While experimenting with #233, a memory segmentation fault occurred. A search of other emacs issues found a potential matching issue as described in att#791. Also, a duplicate PR of att#1489 was submitted. This commit backports that fix. src/cmd/ksh93/edit/history.c: hist_word(): - Switch from using strcpy to memmove as the two strings could overlap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came to light as a consequence of @siteshwar adding unit tests for
interactive emacs mode editing behavior.