fix(dotfiles): allow clearing aliases, disable import#1995
Merged
Conversation
At the moment there are far too many edge cases to handle importing aliases. 1. We need an interactive shell to print aliases. Without it, most shells won't report much. 2. Many people have their shells print things on startup (graphics, fortunes, etc). This could be detected as an attempt to set an alias. Rather than spend the next year finding import edge cases, I'm disabling it for now. There's probably a better way we can do this?
1 task
This comment was marked as spam.
This comment was marked as spam.
Member
Author
|
No matter what? The intent is for it to allow deleting all aliases to remove Atuin set config I'm not sure on a use case for only deleting imported aliases - this was prompted by the linked issue but I think it's a good thing to have regardless. I should probably have clarified a bit better in the PR body |
This comment was marked as spam.
This comment was marked as spam.
Member
Author
|
Ah I see! No, it doesn't. Run is part of the |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment there are far too many edge cases to handle importing aliases.
Rather than spend the next year finding import edge cases, I'm
disabling it for now. There's probably a better way we can do this?
Checks