Replace parse_duration with humantime #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former is no longer maintained, with a long standing security advisory (RUSTSEC-2021-0041).
ellie
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Thanks!
Although the reasoning to switch isn't that strong imo
- humantime has had no commits in a similar time frame (3yrs)
- parse_duration's CVE is applicable when parsing untrusted input, which we do not do
Happy to switch to something more widely used though
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former is no longer maintained, with a long standing security advisory (RUSTSEC-2021-0041). The latter has 4M monthly downloads and no dependency.
Checks