Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for issue #850. #876

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Improve error message for issue #850. #876

merged 2 commits into from
Apr 14, 2023

Conversation

postmath
Copy link
Contributor

I just had the same thing as the person in issue #850: I hadn't exported my $HISTFILE variable (which I think is probably not an uncommon thing to do; for users who don't use atuin it's usually only the shell, not other programs, that interact with the history file). I was able to find the github issue that described it, but figured it would be helpful to include this suggestion in the error message.

@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 7:38pm

@ellie
Copy link
Member

ellie commented Apr 14, 2023

Hey! Thanks for clearing this up - if you can give it a cargo fmt then I'm happy to get it merged!

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you 🙏

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

Either way - thank you so much for the time and effort here ✨

@ellie ellie enabled auto-merge (squash) April 14, 2023 19:46
@ellie ellie merged commit 64671a1 into atuinsh:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants