Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QEMU support for Kitty example #58

Merged
merged 1 commit into from
Aug 19, 2024
Merged

QEMU support for Kitty example #58

merged 1 commit into from
Aug 19, 2024

Conversation

Kswin01
Copy link
Contributor

@Kswin01 Kswin01 commented May 13, 2024

This PR adds QEMU support for LionsOS. It is dependent on the following sDDF PR's: au-ts/sddf#93 and au-ts/sddf#92. It has been tested using the following sDDF branch: https://github.com/au-ts/sddf/tree/qemu.

@Kswin01 Kswin01 force-pushed the qemu branch 2 times, most recently from 99d855b to 1152aeb Compare May 14, 2024 01:38
@Ivan-Velickovic
Copy link
Collaborator

We will also need to update the documentation for running on QEMU.

@Kswin01 Kswin01 force-pushed the qemu branch 2 times, most recently from 0ca821c to 113aa31 Compare May 21, 2024 04:56
@Kswin01 Kswin01 force-pushed the qemu branch 2 times, most recently from 262b7f6 to eb813d5 Compare May 22, 2024 05:49
@Ivan-Velickovic
Copy link
Collaborator

This is very close to being merged, but we've unfortunately been blocked on one remaining issue:

The window size is different to the Odroid-C4, and so the framebuffer has a different size. This means that our modfb.c code would to convert some generic window size to the framebuffer specific size. However, this isn't the proper solution.

The proper solution is to have a proper sDDF device class for graphics rather than a client program (in this case MicroPython) directly writing into the framebuffer. This is what @erichchan999 is working on now, once that is in a working state we can finish this off.

@Ivan-Velickovic
Copy link
Collaborator

This is very close to being merged, but we've unfortunately been blocked on one remaining issue:

I've changed my mind. This is too useful to let it sit here. Everything works except for graphics, we can say that support is experimental on lionsos.org until we get that work.

This PR will unlock all the other example systems working on QEMU as well.

@Kswin01 when you have time, can you rebase this? I will make sure to get it merged quickly so there aren't any more conflicts.

######################################################

# Heartbeat to let the server know we still exist
def heartbeat():
global writer_stream
while True:
# @alwin: is it really necessary to have this in a try-catch?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should sort this out before merging.

Signed-off-by: Krishnan Winter <krishnanwinter1@gmail.com>
@Ivan-Velickovic Ivan-Velickovic merged commit 410e537 into main Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants