Use appropriate size for i2c memory regions #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One page should be plenty for everything in the example no? |
In this example yes, one page should be sufficient. But the i2c components expect the above sizes, we can reduce these as well if needed. Would you prefer to have everything in the example as small as possible? |
|
There is only one client and its always waiting on a response for each request. The payloads are very small and so a page is plenty I think. It would be good to have a comment in the SDF justifying the sizes. |
Kswin01
force-pushed
the
i2c_example_mr
branch
2 times, most recently
from
2206c71
to
5b922e7
Compare
Ivan-Velickovic
force-pushed
the
i2c_example_mr
branch
from
f10896e
to
c3c49e9
Compare
Ivan-Velickovic
previously approved these changes
Jun 26, 2024
Signed-off-by: Krishnan Winter <krishnanwinter1@gmail.com>
Ivan-Velickovic
force-pushed
the
i2c_example_mr
branch
from
c3c49e9
to
48d8032
Compare
Ivan-Velickovic
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The I2C data region is currently bound to 12,800 bytes. The request/response regions are currently limited to 4008 bytes.