third party noop library #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…my own noop (you jsut don't do that)
|
Awesome, looks like tests passed. |
|
Hey @grantholly if you weren't aware already, you haven't uploaded your PGP key to GitHub yet. |
| @@ -1,7 +1,7 @@ | |||
| 'use strict' | |||
|
|
|||
| var isCI = require('is-ci') | |||
| var noop = function () {} | |||
| var noop = require('node-noop').noop | |||
There was a problem hiding this comment.
Did you write any unit tests for this?
There was a problem hiding this comment.
I didn't write any new tests.
|
what the hell did I just read |
|
At first look, I was very sceptic about this change. But I appreciate this, after a closer look at |
Guria
approved these changes
Jan 4, 2019
|
You should use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following software design best practices I'm not going to be rolling my own noop (you jsut don't do that)
This addresses #90